Refactor scala.quoted.matching #8479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing `scala.quoted._` should give access to all the basic functionalities, but currently some half of them need the extra import for `scala.quoted.matching._`. * Move `scala.quoted.matching.summonExpr` to `scala.quoted.Expr.summon` * Move basic quote extractors from `scala.quoted.matching` to `scala.quoted`
Currently we have `Expr.ofSeq` and `ExprSeq.unapply` to handle such cases. Instead we provide a single `Exprs` that contains an `apply` and `unapply`. Furthermore having both `Expr.ofSeq` and `Expr.ofList` has lead to confusions on which one to use for varargs. This will help guide users to the correct logic to use for varargs.
Instead of having a special concept to extract values out of sequences, with this change, we can take advantage of composition with `Exprs`. The old `ConstSeq` and `ValueSeq` are deprecated to reduce the sumber of concepts in the API.
nicolasstucki
commented
Mar 9, 2020
nicolasstucki
force-pushed
the
refactor-quoted-matching
branch
from
1a94411 to
be3f2d7
Compare
Co-Authored-By: Fengyun Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
scala.quoted._should give access to all the basic functionalities, but currently some half of them need the extra import forscala.quoted.matching._.scala.quoted.matching.summonExprtoscala.quoted.Expr.summonscala.quoted.matchingtoscala.quotedExprlogic intoVarargs(Expr.ofSeqandExprSeq.unapply)ConstsandValues. Then removeConstSeqandValueSeq